Commit Graph

9 Commits

Author SHA1 Message Date
ethernet
25ce047f98 fix(footguns): utf-8-sig on all reads flagged by check-windows-footguns (164 sites)
The 4,272-commit upstream merge brought 164 new utf-8 read violations
across 96 files. Class-fixed: reads utf-8-sig, writes unchanged.
check-windows-footguns.py --all: 164 -> 0.
2026-09-04 14:46:24 -04:00
Teknium
e83816a4d1 review-fix(comments): restore lost #NNNN rationale comments across non-test source (mechanical sweep, condensed, code unchanged)
For each issue anchor present in BASE 63279301bc non-test .py and absent on HEAD, the BASE comment/docstring block was re-attached at the HEAD location of the code it explained (matched by the distinctive code line / enclosing def). Sentences already covered by an existing HEAD comment were deduped; the issue number always survives. Insert-only: no code lines changed.
2026-09-03 09:44:26 -07:00
Teknium
23b9ffc4fa fix(integration): restore subprocess stdin=DEVNULL / utf-8 encoding guards and windows-footgun gates dropped by round-3 compaction
Repo scanners (check_subprocess_stdin, check-windows-footguns --all) flagged 21 sites where
the r3 single-line collapses lost stdin=DEVNULL, encoding='utf-8'/errors='replace', the
'# windows-footgun: ok' same-line marker, or the getattr(os, 'geteuid') gate. Each guard is
restored at the call site (real portability/hang fixes, not suppressions).
2026-09-03 02:46:19 -07:00
Teknium
67257678f1 refactor(cli): compact worktree_ops docstrings and comments to summary + invariants 2026-09-02 23:39:34 -07:00
Teknium
04b611ac73 refactor(cli): route worktree lock listing through _git_out; fold single-use locals in worktree_ops 2026-09-02 23:27:49 -07:00
Teknium
9b650f29dc refactor(cli): collapse worktree_ops multi-line calls, boolean ladders and single-use locals 2026-09-02 23:22:05 -07:00
Teknium
68697be1e8 refactor(cli): unify worktree_ops git stdout probes behind _git_out; hoist subprocess import; dict-dispatch preserve verdicts 2026-09-02 22:53:33 -07:00
Teknium
4e816f16c1 refactor(cli): join short multi-line calls (AST-identical) 2026-09-02 19:07:38 -07:00
Teknium
8c9c7a041a refactor(cli): extract git worktree machinery into hermes_cli/worktree_ops.py (cli re-exports) 2026-09-02 18:44:44 -07:00