Commit Graph

1983 Commits

Author SHA1 Message Date
Teknium
b1047e80d1 review-fix(comments): restore lost #NNNN rationale comments (sweep, remaining files) 2026-09-03 09:44:36 -07:00
Teknium
e83816a4d1 review-fix(comments): restore lost #NNNN rationale comments across non-test source (mechanical sweep, condensed, code unchanged)
For each issue anchor present in BASE 63279301bc non-test .py and absent on HEAD, the BASE comment/docstring block was re-attached at the HEAD location of the code it explained (matched by the distinctive code line / enclosing def). Sentences already covered by an existing HEAD comment were deduped; the issue number always survives. Insert-only: no code lines changed.
2026-09-03 09:44:26 -07:00
Teknium
812943b3ed review-fix(suppress-audit): whatsapp adapter, skill_manager_tool, skill_usage — restore BASE exception semantics 2026-09-03 09:42:58 -07:00
Teknium
35ce61d1b3 review-fix(suppress-audit): dashboard_procs ancestor walk, mem0 post_setup — restore BASE exception semantics 2026-09-03 09:39:31 -07:00
Teknium
cb9b7c36f3 review-fix(photon): restore credential_summary() (public on main) + test_credential_summary_no_secret_leak
ethernet8023: the no-leak test was deleted alongside the function it pinned; the
display-only credential status is live in print_credential_summary. credential_summary
restored byte-identical to BASE so the leak contract is CI-pinned again.
2026-09-03 09:36:07 -07:00
Teknium
fb14bc4e11 review-fix(whitespace): strip trailing whitespace and EOF blank lines introduced by this PR
Trailing-whitespace-only edits so 'git diff --check BASE HEAD' is clean
(16 diagnostics across 11 files). No code changes.
2026-09-03 09:31:54 -07:00
Teknium
022785a541 Merge origin/main (63279301bc): reasoning-mandatory 400 recovery folded into turn_recovery/error_classifier/models_reasoning_caps 2026-09-03 05:36:21 -07:00
Teknium
b57f17bd4b fix(late-slices): restore subprocess footgun guards re-collapsed by r3-30/33/34/36 tails; telegram format_message stays self-free (staticmethod via class ref); _captured_exec explicit shell/env kwargs 2026-09-03 05:33:46 -07:00
Teknium
f6bd1633f7 fix(reasoning): GLM-5.3 on Nous/OpenRouter no longer 400s when thinking is disabled
Reasoning-mandatory routes answer reasoning: {enabled: false} with HTTP 400
"Reasoning is mandatory for this endpoint and cannot be disabled". Hermes
sends that disable for /reasoning none, agent.reasoning_effort: none, and the
one-shot thinking-exhaustion continuation override (which GLM-5.3-flash
triggers on its own). The Nous profile's catalog guard swallows the disable
only when its per-process capability cache already says mandatory; a gateway
that warmed the cache before the route flipped kept sending it, and the 400
was classified as a non-retryable format_error that aborted the turn.

- error_classifier: new reasoning_mandatory reason (retryable, no fallback,
  no compression), matched before the request-validation branch.
- conversation_loop: one-shot recovery — set agent._reasoning_disable_rejected,
  queue a catalog refresh for the provider, retry.
- chat_completion_helpers: _reasoning_config_for_wire drops every disable
  (configured or ephemeral) once the route has rejected one.
- hermes_cli/models: refresh_reasoning_caps_async(provider) forces a
  background re-fetch of the Nous/OpenRouter catalog.
- openrouter profile: omit a disable when the catalog marks the route
  mandatory (parity with the Nous profile).

Live: z-ai/glm-5.3-flash on the Portal with a poisoned mandatory:false cache.
Before: turn aborted with the 400. After: one retry, thinking stays on, turn
completes.
2026-09-03 05:20:11 -07:00
Teknium
5dcd3b2620 ci: ASYNC220 ignore follows Popen to run_shutdown.py; windows-only tests patch the defining module; whatsapp taskkill kwargs explicit 2026-09-03 05:12:25 -07:00
Teknium
8ae52dd93c Merge simp/r3-30 (late tail) into hermes/simplify-codebase 2026-09-03 05:04:08 -07:00
Teknium
0071ba9965 Merge origin/main (561b053f79) into simp/forwardport: forward-port 220 main commits into the simplified tree 2026-09-03 03:31:03 -07:00
Teknium
48b336ef7e fix(integration): fal image_gen plugin keeps trailing-comma passthrough whitelist the capability-coverage test keys on
test_every_intree_plugin_declares_what_it_implements detects upscale support via the literal
'"upscale",' whitelist entry; the r3 tuple collapse turned it into '"upscale")'. Tool schema
(get_tool_definitions dump) is byte-identical to base 113f04616b before and after.
2026-09-03 02:47:01 -07:00
Teknium
23b9ffc4fa fix(integration): restore subprocess stdin=DEVNULL / utf-8 encoding guards and windows-footgun gates dropped by round-3 compaction
Repo scanners (check_subprocess_stdin, check-windows-footguns --all) flagged 21 sites where
the r3 single-line collapses lost stdin=DEVNULL, encoding='utf-8'/errors='replace', the
'# windows-footgun: ok' same-line marker, or the getattr(os, 'geteuid') gate. Each guard is
restored at the call site (real portability/hang fixes, not suppressions).
2026-09-03 02:46:19 -07:00
Teknium
ab48dccf97 refactor(plugins/telegram): split send/inbound god methods into phase helpers, dedupe media/retry paths, dispatch tables, drop dead code (8817->6578 LOC, 13073-case Bot API payload parity) 2026-09-03 01:29:35 -07:00
Teknium
d6bb94a1fb fix(meta-ai): declare supports_vision_tool_messages=False — Muse Spark 400s on image tool results
Muse Spark accepts images on user turns but returns HTTP 400
invalid_request_error 'messages[N].content did not match any supported
type' when the vision_analyze multimodal envelope lands in a role:tool
message. With the profile veto now honored by the vision fast-path gates,
declaring the limitation routes tool-result images through the aux-LLM
text path while user-message vision stays enabled.

Fixes #101668
Refs #47742
2026-09-03 00:57:40 -07:00
Teknium
ce08af6139 refactor(plugins/whatsapp,wecom): dedupe send/media/stream paths, drop dead helpers, compact docs (4357->3048 LOC, bridge/WeCom payload + crypto parity verified) 2026-09-03 00:40:56 -07:00
Teknium
44023a3d23 refactor(plugins/teams_pipeline,spotify,security-guidance): phase-split pipeline, dedupe Graph/Spotify clients, compact docs (3140->2631 LOC, --help/schema/pattern parity verified) 2026-09-03 00:33:14 -07:00
Teknium
2028dcb91c refactor(plugins/web,video_gen): unify web-provider/video_gen plugin scaffolding into _common helpers, drop dead code (3739->2755 LOC, request/result parity verified) 2026-09-03 00:33:11 -07:00
Teknium
e52b0ba930 Merge branch 'simp/r3-27-W4' into simp/integration3 2026-09-03 00:11:47 -07:00
Teknium
db070745fc Merge branch 'simp/r3-27-W3' into simp/integration3 2026-09-03 00:11:46 -07:00
Teknium
4dc7737ab3 Merge branch 'simp/r3-27-W2' into simp/integration3 2026-09-03 00:11:44 -07:00
Teknium
c2f889310c Merge branch 'simp/r3-27-W1' into simp/integration3 2026-09-03 00:11:42 -07:00
Teknium
d3b24a5d45 refactor(openviking): compact prefetch client selection, tool-call indexing, search/browse payloads 2026-09-03 00:10:51 -07:00
Teknium
4b4502a429 refactor(honcho): merge pre-build and cached OAuth refresh hooks into one _refresh_oauth 2026-09-03 00:09:52 -07:00
Teknium
0152c3840d Merge branch 'simp/r3-29-F' into simp/integration3 2026-09-03 00:09:51 -07:00
Teknium
539c03b96b Merge branch 'simp/r3-29-E' into simp/integration3 2026-09-03 00:09:49 -07:00
Teknium
de168dc3cc Merge branch 'simp/r3-29-D' into simp/integration3 2026-09-03 00:09:48 -07:00
Teknium
a6faffadd8 Merge branch 'simp/r3-29-C' into simp/integration3 2026-09-03 00:09:46 -07:00
Teknium
0d1ee53995 Merge branch 'simp/r3-29-B' into simp/integration3 2026-09-03 00:09:44 -07:00
Teknium
da1288a6b1 Merge branch 'simp/r3-29-A' into simp/integration3 2026-09-03 00:09:41 -07:00
Teknium
4b5887993d Merge branch 'simp/r3-26-H' into simp/integration3 2026-09-03 00:09:29 -07:00
Teknium
c1ffedf438 Merge branch 'simp/r3-26-G' into simp/integration3 2026-09-03 00:09:26 -07:00
Teknium
a3a44db4dc refactor(mattermost): flatten download retry loop, msg_type ladder, ws frame kind local, packed register() 2026-09-03 00:09:24 -07:00
Teknium
c190cf7943 Merge branch 'simp/r3-26-F' into simp/integration3 2026-09-03 00:09:24 -07:00
Teknium
e183199c3f refactor(openviking): flatten profile truncation, memory listing, forget-uri and remember payload building 2026-09-03 00:09:06 -07:00
Teknium
2c4db54a31 refactor(image_gen,browser): AST-neutral closer hugging after edits 2026-09-03 00:08:53 -07:00
Teknium
66c09a1a7c refactor(hindsight): extract embedded-LLM wizard step, walrus prompt guards 2026-09-03 00:08:33 -07:00
Teknium
2971f80305 refactor(image_gen/openai,openai-codex): drop _MODELS copies of GPT_IMAGE_2_TIERS 2026-09-03 00:08:26 -07:00
Teknium
5b67e31699 Merge branch 'simp/r3-28' into simp/integration3 2026-09-03 00:08:06 -07:00
Teknium
412a8c5ee1 Merge branch 'simp/r3-26' into simp/integration3 2026-09-03 00:08:01 -07:00
Teknium
8e638fc87a refactor(sms): fatal-precondition ladder, shared Messages endpoint/aiohttp probe, single webhook rejection path 2026-09-03 00:07:51 -07:00
Teknium
086859bdfa refactor(openviking): move ovcli profile write into the setup wizard, simplify batch post loop 2026-09-03 00:07:42 -07:00
Teknium
a905beac5e refactor(honcho): unify cli peer/tokens show-or-set skeleton, fold status env-fallback and wizard int-parsing 2026-09-03 00:06:52 -07:00
Teknium
d1a0cdae2c refactor(image_gen,browser): compact module/function docstrings and comments across providers (WHYs kept) 2026-09-03 00:06:34 -07:00
Teknium
ac2b23c81b refactor(hindsight): compact log-call layouts and tool-recall formatting 2026-09-03 00:06:31 -07:00
Teknium
5729b34309 refactor(raft): fold _validate_bridge_token into _authorized, drop unreferenced runtime_session property, walrus guards, coerce_port for drain max, import ordering 2026-09-03 00:06:07 -07:00
Teknium
3fd456c96e refactor(openviking): share client health probe, drop unread profile data, inline writer spawn 2026-09-03 00:06:05 -07:00
Teknium
229f530d34 refactor(photon): collapse defensive layers + fold branches across adapter/auth/cli (2813->2749 LOC) 2026-09-03 00:05:57 -07:00
Teknium
9ae8614c65 refactor(matrix): drop docstrings that restate the method name (base ABC documents the public surface) (2995->2954) 2026-09-03 00:05:24 -07:00