From fd60c70375d875bb7cefaa80eb60cf8ec10edddd Mon Sep 17 00:00:00 2001 From: teknium1 <127238744+teknium1@users.noreply.github.com> Date: Mon, 14 Sep 2026 14:41:50 -0700 Subject: [PATCH] test: assert skills-guard scanner version is past v1, not pinned to v2 The pin to "skills-guard-v2" was a change-detector: every rule change that bumps the scanner version (this PR moves to v3 so cached verdicts re-scan) turned it red. The intent was "cached v1 verdicts are invalidated", so assert the contract instead of the current value. --- tests/tools/test_skills_guard_agent_config.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/tools/test_skills_guard_agent_config.py b/tests/tools/test_skills_guard_agent_config.py index 9d3162b087..42da5becba 100644 --- a/tests/tools/test_skills_guard_agent_config.py +++ b/tests/tools/test_skills_guard_agent_config.py @@ -34,10 +34,11 @@ def _scan(tmp_path: Path, content: str): return scan_skill(skill_dir, source="community/test") -# The scanner version moved to v2 precisely so cached v1 dangerous verdicts -# for previously-blocked skills are invalidated and re-scanned. +# The scanner version moved past v1 precisely so cached v1 dangerous verdicts +# for previously-blocked skills are invalidated and re-scanned. Later bumps +# are expected whenever rules change; only regressing to v1 is a bug. def test_scanner_version_bumped(): - assert SCANNER_VERSION == "skills-guard-v2" + assert SCANNER_VERSION != "skills-guard-v1" class TestFalsePositivesUnblocked: