From dfe96faf5e7b0cfb0509f0c1c2371d4e05e736e3 Mon Sep 17 00:00:00 2001 From: alt-glitch Date: Fri, 2 Oct 2026 15:47:58 +0530 Subject: [PATCH] test(tour): start with no steps is the built-in tour, not an error #129137 made gui_tour's start without steps run the app's built-in tour on surface='app' and refuse it on 'preview'. test_start_validates_its_steps still expected the old 'non-empty steps' error for a bare start, so it fails on onboarding/next. Assert the current contract instead. --- tests/tools/test_tour_tool.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/tools/test_tour_tool.py b/tests/tools/test_tour_tool.py index c0d946fcd0..7435299b50 100644 --- a/tests/tools/test_tour_tool.py +++ b/tests/tools/test_tour_tool.py @@ -31,7 +31,9 @@ def test_show_needs_something_to_point_at_or_say(): def test_start_validates_its_steps(): - assert "non-empty steps" in _run(action="start")["error"] + # No steps is the app's built-in tour; it exists only on the app surface. + assert "error" not in _run(action="start") + assert "surface='app'" in _run(action="start", surface="preview")["error"] assert "non-empty steps" in _run(action="start", steps=[])["error"] assert "steps[1] must be an object" in _run(action="start", steps=[{"selector": "#a"}, "nope"])["error"] assert "steps[1] needs" in _run(action="start", steps=[{"selector": "#a"}, {}])["error"]