From dafe7d14c8e1b24c28ec99eec4136dcdbd67f5e9 Mon Sep 17 00:00:00 2001 From: ethernet Date: Fri, 18 Sep 2026 11:38:51 -0400 Subject: [PATCH] fix(install-e2e): HERMES_RUNTIME_DIR is the tools dir, not its parent The step globbed uv-* under $HERMES_RUNTIME_DIR\tools, but that variable already points at the tools directory (D:\a\_temp\setup-pm\tools), so it looked for ...\tools\tools and died with "Cannot find path". Verified against a real toolchain layout with HERMES_RUNTIME_DIR set to the tools directory, the way CI sets it. --- .github/workflows/install-e2e-windows-run.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/install-e2e-windows-run.yml b/.github/workflows/install-e2e-windows-run.yml index c5f5ad63ae..f621a7b3c5 100644 --- a/.github/workflows/install-e2e-windows-run.yml +++ b/.github/workflows/install-e2e-windows-run.yml @@ -204,13 +204,13 @@ jobs: # The driver therefore runs that turn under e2e-assets/pty-run.py, which uses # pywinpty: the same ConPTY spawner the product uses on Windows, pinned to the # version pyproject.toml requires. Install it with uv (the toolchain python ships - # without pip), resolved out of the toolchain root because workflow steps do not - # get the tools on PATH; the import check proves it landed. + # without pip) out of HERMES_RUNTIME_DIR, which is the tools directory itself and + # is not on PATH for workflow steps; the import check proves it landed. - name: Install the pseudoconsole runner's dependency shell: pwsh run: | - $uvDir = Get-ChildItem (Join-Path $env:HERMES_RUNTIME_DIR 'tools') -Filter 'uv-*' -Directory | Select-Object -First 1 - if (-not $uvDir) { throw "uv not found under $env:HERMES_RUNTIME_DIR\tools" } + $uvDir = Get-ChildItem $env:HERMES_RUNTIME_DIR -Filter 'uv-*' -Directory | Select-Object -First 1 + if (-not $uvDir) { throw "uv not found under $env:HERMES_RUNTIME_DIR" } & (Join-Path $uvDir.FullName 'uv.exe') pip install --system --python $env:HERMES_PYTHON --quiet "pywinpty==3.0.5" if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } python -c "import winpty; print('pty-run dependency ready')"