From d25bbd01b75cf2d472a88857af7b7f056dd0f9f7 Mon Sep 17 00:00:00 2001 From: teknium1 <127238744+teknium1@users.noreply.github.com> Date: Sun, 27 Sep 2026 01:26:49 -0700 Subject: [PATCH] test(e2e/network): drop the #124653 gate; the channel 503 cell passes The known_failure wrapper on test_channel_503_with_retry_after_is_retried_then_updates keyed on the one-attempt channel read. With update-path retries it passes, so the cell asserts plainly again. --- .../e2e/core/upgrade/network/test_offline_and_flaky.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/e2e/core/upgrade/network/test_offline_and_flaky.py b/tests/e2e/core/upgrade/network/test_offline_and_flaky.py index ce5dfccbf7..23d9a03109 100644 --- a/tests/e2e/core/upgrade/network/test_offline_and_flaky.py +++ b/tests/e2e/core/upgrade/network/test_offline_and_flaky.py @@ -23,7 +23,6 @@ import shutil import pytest -from tests.e2e.core._pending_fixes import known_failure from tests.e2e.core.upgrade import _helpers as H from tests.e2e.core.upgrade import _install_helpers as I from tests.e2e.core.upgrade.network import _netedge as N @@ -83,13 +82,8 @@ def test_channel_503_with_retry_after_is_retried_then_updates(inst): finally: edge.close() reads = [h for h in edge.proxy.requests(S.ASSETS) if h.path == MAIN_RECORD] - with known_failure( - r"\(1 channel read\(s\)\)[\s\S]*Channel read unavailable: HTTP 503", - "gated on #124653: the channel record read makes one attempt, so a single 503 " - "with Retry-After aborts `hermes update`", - ): - assert r.rc == 0 and inst.head() == new, ( - f"a single transient 503 aborted the update ({len(reads)} channel read(s))\n" + r.report(inst)) + assert r.rc == 0 and inst.head() == new, ( + f"a single transient 503 aborted the update ({len(reads)} channel read(s))\n" + r.report(inst)) assert len(reads) >= 2, f"update succeeded without re-reading the record ({reads})\n" + r.report(inst)