From cfc55d34872a17be91bd9b93a29b9f41595f7bc2 Mon Sep 17 00:00:00 2001 From: fangliquanflq Date: Sun, 16 Aug 2026 07:54:37 +0800 Subject: [PATCH] fix(config): remove obsolete cwd warning parameter --- hermes_cli/config.py | 2 +- tests/hermes_cli/test_deprecated_cwd_warning.py | 17 +++++++++++------ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hermes_cli/config.py b/hermes_cli/config.py index d5372eb3fe..c8c6e6e105 100644 --- a/hermes_cli/config.py +++ b/hermes_cli/config.py @@ -2223,7 +2223,7 @@ def print_config_warnings(config: Optional[Dict[str, Any]] = None) -> None: sys.stderr.write("\n".join(lines) + "\n\n") -def warn_deprecated_cwd_env_vars(config: Optional[Dict[str, Any]] = None) -> None: +def warn_deprecated_cwd_env_vars() -> None: """Warn if MESSAGING_CWD or TERMINAL_CWD is set in .env instead of config.yaml. These env vars are deprecated — the canonical setting is terminal.cwd diff --git a/tests/hermes_cli/test_deprecated_cwd_warning.py b/tests/hermes_cli/test_deprecated_cwd_warning.py index f01e103e1c..955d98d6de 100644 --- a/tests/hermes_cli/test_deprecated_cwd_warning.py +++ b/tests/hermes_cli/test_deprecated_cwd_warning.py @@ -21,7 +21,7 @@ class TestDeprecatedCwdWarning: from hermes_cli.config import warn_deprecated_cwd_env_vars - warn_deprecated_cwd_env_vars(config={}) + warn_deprecated_cwd_env_vars() assert capsys.readouterr().err == "" @@ -38,7 +38,7 @@ class TestDeprecatedCwdWarning: from hermes_cli.config import warn_deprecated_cwd_env_vars - warn_deprecated_cwd_env_vars(config={}) + warn_deprecated_cwd_env_vars() captured = capsys.readouterr() assert "MESSAGING_CWD" in captured.err @@ -49,11 +49,16 @@ class TestDeprecatedCwdWarning: def test_dotenv_terminal_cwd_warns_with_explicit_config( self, monkeypatch, tmp_path, capsys ): - _write_env(monkeypatch, tmp_path, "TERMINAL_CWD=/legacy/path\n") + hermes_home = _write_env( + monkeypatch, tmp_path, "TERMINAL_CWD=/legacy/path\n" + ) + (hermes_home / "config.yaml").write_text( + "terminal:\n cwd: /current/path\n", encoding="utf-8" + ) from hermes_cli.config import warn_deprecated_cwd_env_vars - warn_deprecated_cwd_env_vars(config={"terminal": {"cwd": "/current/path"}}) + warn_deprecated_cwd_env_vars() assert "TERMINAL_CWD=/legacy/path" in capsys.readouterr().err @@ -69,7 +74,7 @@ class TestDeprecatedCwdWarning: from hermes_cli.config import warn_deprecated_cwd_env_vars - warn_deprecated_cwd_env_vars(config={}) + warn_deprecated_cwd_env_vars() assert capsys.readouterr().err == "" @@ -81,6 +86,6 @@ class TestDeprecatedCwdWarning: monkeypatch.setattr(config_module, "load_env", raise_read_error) - config_module.warn_deprecated_cwd_env_vars(config={}) + config_module.warn_deprecated_cwd_env_vars() assert capsys.readouterr().err == ""