From cb399b56d964306bfad18b20edee30f88f777bf0 Mon Sep 17 00:00:00 2001 From: kshitijk4poor <82637225+kshitijk4poor@users.noreply.github.com> Date: Sat, 26 Sep 2026 20:01:41 +0530 Subject: [PATCH] test(cron): say which failure's notice the yield case releases The comment claimed the notice goes out immediately. In production will_retry runs before mark_job_run, so the first failure (5m rung beats the 10m run) is held; only the attempt-1 failure asserted here yields. --- tests/cron/test_unreachable_retry.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/cron/test_unreachable_retry.py b/tests/cron/test_unreachable_retry.py index 959b08d1ee..f82744ee12 100644 --- a/tests/cron/test_unreachable_retry.py +++ b/tests/cron/test_unreachable_retry.py @@ -97,7 +97,8 @@ def test_will_retry_mirrors_plan_retry_yield(tmp_cron_home): jm = get_job(mid["id"]) assert jm is not None # 10m cadence beats the 15m and 30m rungs: the ladder can never climb past attempt 1, - # so the exhaustion escape is unreachable and the notice must go out immediately. + # so the exhaustion escape is unreachable. At attempt 1 the next (15m) rung loses to the + # 10m run, so this failure's notice goes out rather than being held for a retry. assert jm[ur.STATE_KEY]["attempt"] == 1 assert ur.will_retry(jm) is False, "10m cadence beats the 15m rung: yielded, notice goes out"