From bf029cb147ffc0ce5e5b5203b758391a4b68fcdf Mon Sep 17 00:00:00 2001 From: ethernet Date: Fri, 4 Sep 2026 03:57:14 -0400 Subject: [PATCH] fix(pm-bundle): drop dead shim check from payload smoke test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit smoke-payload.sh's third check ran '../bin/hermes' — a self-relative CLI trampoline minted only by the desktop release workflow (build-bundled-desktop.mjs → mint-launchers.py). 'pm bundle --out' stages repo+store+venv only, so the shim never exists and every pm-bundle lane died at that check (exit 127) since the workflow's birth (Aug 28, same error on every branch). Keep the real boot checks (store python imports, hermes_cli entrypoint --version, pm doctor); drop the shim check. --- scripts/smoke-payload.sh | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/scripts/smoke-payload.sh b/scripts/smoke-payload.sh index 80a8a7faec..6a4c029fba 100644 --- a/scripts/smoke-payload.sh +++ b/scripts/smoke-payload.sh @@ -1,8 +1,9 @@ #!/bin/bash -# Smoke-test a staged payload the way the DESKTOP spawns it (the self- -# relative CLI trampoline, which sets its own PYTHONPATH) plus the raw store -# python with an explicit PYTHONPATH (the legacy spawn). cwd at the staged -# repo, no network, lazy installs off. Usage: smoke-payload.sh +# Smoke-test a staged pm payload (`pm bundle --out`): the raw store python +# boots hermes_cli/pm out of the staged repo snapshot (cwd at the staged +# repo, no network, lazy installs off). The desktop's self-relative CLI +# trampoline is minted only by the desktop release workflow, not by +# `pm bundle`, so it is not exercised here. Usage: smoke-payload.sh set -e PAYLOAD="${1:?usage: smoke-payload.sh }" cd "$PAYLOAD" @@ -40,12 +41,6 @@ env -u PYTHONPATH -u PYTHONHOME \ PYTHONPATH="$SP" \ "$PY" -m hermes_cli.main --version -echo "— the self-relative CLI trampoline boots with NO PYTHONPATH (it sets its own) —" -SHIM="../bin/hermes$(case "$(uname -s)" in MINGW*|MSYS*|CYGWIN*) echo .exe ;; esac)" -env -u PYTHONPATH -u PYTHONHOME \ - HERMES_RUNTIME_DIR="$TOOLS" HERMES_DISABLE_LAZY_INSTALLS=1 \ - "$SHIM" --version - echo "— pm sees the staged tools —" env -u PYTHONPATH -u PYTHONHOME \ HERMES_RUNTIME_DIR="$TOOLS" HERMES_DISABLE_LAZY_INSTALLS=1 \