From be98c68fa36190f8087bb9961c600234567e85ce Mon Sep 17 00:00:00 2001 From: teknium1 <127238744+teknium1@users.noreply.github.com> Date: Fri, 18 Sep 2026 03:57:59 -0700 Subject: [PATCH] fix: call _resolve_pre_update_backup_mode directly in the receipt classifier The resolver only does getattr() on args and already swallows its own config-load errors, so the try/except around it could never fire; drop it (review follow-up, no behaviour change). --- hermes_cli/update_cmd.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hermes_cli/update_cmd.py b/hermes_cli/update_cmd.py index dae4dfa550..ba2c2ce6e1 100644 --- a/hermes_cli/update_cmd.py +++ b/hermes_cli/update_cmd.py @@ -174,11 +174,7 @@ def _record_pre_update_backup_outcome(args, snapshot_id) -> None: if snapshot_id: _record_update_step("pre_update_backup", True, f"snapshot={snapshot_id}") return - try: - mode = _resolve_pre_update_backup_mode(args) - except Exception: - mode = "" - if mode == "off": + if _resolve_pre_update_backup_mode(args) == "off": reason = ("disabled by --no-backup" if getattr(args, "no_backup", False) else "disabled by updates.pre_update_backup (mode: off)") _record_update_skip("pre_update_backup", reason)