From adcbe3379bd2e4cd97a6007d382fcb031f76eb55 Mon Sep 17 00:00:00 2001 From: Brooklyn Nicholson Date: Fri, 25 Sep 2026 18:59:10 -0500 Subject: [PATCH] test(desktop): adapt #51833 badge tests to the flash variant chip Rebase fallout: main's badge-chip tests assumed the effort chip directly follows the name span, and matched the composed 'Gemini 2.5 Flash' text. The -flash variant chip now sits between name and effort badge, and the name no longer contains the variant. Find the truncating name span by class instead of previousElementSibling, assert the name stays free of variant and effort, and match the leaf 'Gemini 2.5' text. --- .../desktop/src/app/shell/model-catalog-menu.test.tsx | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/apps/desktop/src/app/shell/model-catalog-menu.test.tsx b/apps/desktop/src/app/shell/model-catalog-menu.test.tsx index 407a1fb764..a777e1e269 100644 --- a/apps/desktop/src/app/shell/model-catalog-menu.test.tsx +++ b/apps/desktop/src/app/shell/model-catalog-menu.test.tsx @@ -111,12 +111,15 @@ describe('the reasoning-effort badge (#51833)', () => { expect(badge.className).toContain('rounded-sm') // …as a SIBLING of the truncating model-name span, so it can never read as - // part of a differently-named model. - const nameSpan = badge.previousElementSibling + // part of a differently-named model. The `-flash` variant tag is its own + // chip between them (#118083); the name itself stays free of both. + const nameSpan = badge.parentElement?.querySelector('.truncate') expect(nameSpan?.className).toContain('truncate') expect(nameSpan?.contains(badge)).toBe(false) - expect(nameSpan?.textContent?.toLowerCase()).toContain('gemini 2.5 flash') + expect(nameSpan?.textContent?.toLowerCase()).toContain('gemini 2.5') + expect(nameSpan?.textContent?.toLowerCase()).not.toContain('flash') + expect(nameSpan?.textContent?.toLowerCase()).not.toContain('high') }) it('drops the effort badge entirely when the model has no reasoning support', async () => { @@ -133,7 +136,7 @@ describe('the reasoning-effort badge (#51833)', () => { renderMenu({ effort: 'high', model: 'gemini-2.5-flash', provider: 'google' }) - await screen.findByText(/Gemini 2\.5 Flash/i) + await screen.findByText('Gemini 2.5') await waitFor(() => { expect(screen.queryByText('High')).toBeNull()