hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 31 Packages Projects Releases Wiki Activity

test: cover persist_on_release in sandbox stub contracts and shutdown kill fakes

Browse Source 
The four CI reds from #41225:
- persist_on_release is a background-only terminal modifier: join the
  sandbox blocked sets (precedent: heartbeat, 9acd0d33b6) in
  _TERMINAL_BLOCKED_PARAMS and the stub-drift tests' mirrors.
- The gateway shutdown sweep passes source="gateway_shutdown" so
  persisted jobs are still killed on host exit; the two shutdown tests'
  kill_all fakes now accept and assert that kwarg instead of raising
  TypeError that _quiet_step silently swallowed.
This commit is contained in:
Brooklyn Nicholson
2026-09-25 13:24:45 -05:00
committed by brooklyn!
parent ec5c9c738a
commit ac2ffe60d0
5 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/code_execution_rpc.py
View File

@@ -22,7 +22,7 @@ from tools.registry import tool_error
logger = logging.getLogger("tools.code_execution_tool")
# Terminal parameters that must not be used from ephemeral sandbox scripts.
_TERMINAL_BLOCKED_PARAMS = {"background", "pty", "notify", "notify_on_complete", "watch_patterns", "heartbeat"}
_TERMINAL_BLOCKED_PARAMS = {"background", "pty", "notify", "notify_on_complete", "watch_patterns", "heartbeat", "persist_on_release"}
def _default_dispatch(task_id):