hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

refactor: MessageEvent to gateway/platforms/event.py; ElicitationHandler takes a call_context thunk

Browse Source 
Breaks the two import cycles that forced Protocol stand-ins in the F821 sweep, so the two
sites now name the real types.

gateway/platforms/event.py (new leaf): MessageType, ProcessingOutcome, MessageEvent moved
out of base.py verbatim. Their only dependency is gateway.session.SessionSource; base.py
imported helpers.py at module level, so helpers could not name MessageEvent. Now
TextBatchAggregator is typed by the real MessageEvent. 249 importers repointed
(`from gateway.platforms.base import` -> `.event`, preserving each import's layout);
gateway.platforms.__init__ re-exports from .event. The three revert-scheduled PLUGIN-COMPAT
pointers that named these symbols (gateway.slash_commands → MessageType, dingtalk → MessageType,
photon → ProcessingOutcome) and their COMPAT_MANIFEST rows now target gateway.platforms.event.
Docs updated: ADDING_A_PLATFORM.md, adding-platform-adapters.md (en + zh-Hans).

tools/mcp_tool_sampling.py: ElicitationHandler no longer holds a back-reference to its
MCPServerTask (mcp_tool imports sampling, so the task type cannot be named there). It only
ever read owner._pending_call_context, so it takes `call_context: Callable[[], Context | None]`
and MCPServerTask passes `lambda: self._pending_call_context`. The consent call is one
`functools.partial`, run directly or inside the captured Context.

ty on the 11 touched production files vs origin/main: 0 new diagnostics, 14 resolved.
(The one `source: SessionSource = None` diagnostic moves with the class; typing it Optional
exposes ~60 unguarded call sites — separate follow-up.)

Tests: tests/gateway + tests/plugins + tests/tools + touched files, 18,235 passed; the 31
failures reproduce identically on origin/main (macOS /private/tmp, systemd socket,
long-path fixtures, live-service tests).
This commit is contained in:
kshitijk4poor
2026-09-04 22:37:25 +05:30
committed by kshitij
parent c5ff900761
commit ab2f4602de
259 changed files with 524 additions and 464 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
COMPAT_MANIFEST.md
View File

@@ -1025,7 +1025,7 @@ to the public equivalent or the new module. Test monkeypatch seams are likewise
|---|---|---|
| `Any` | import | `typing` |
| `HISTORY_UNREADABLE` | moved-lazy | `gateway.slash_commands_status` |
| `MessageType` | moved-lazy | `gateway.platforms.base` |
| `MessageType` | moved-lazy | `gateway.platforms.event` |
| `SessionSource` | moved-lazy | `gateway.session` |
| `base_url_host_matches` | moved-lazy | `utils` |
| `build_session_key` | moved-lazy | `gateway.session` |
@@ -2547,7 +2547,7 @@ to the public equivalent or the new module. Test monkeypatch seams are likewise
|---|---|---|
| `DINGTALK_TYPE_MAPPING` | moved-lazy | `plugins.platforms.dingtalk.inbound` |
| `EXT_MAP` | restored-def | `(deleted; BASE body restored)` |
| `MessageType` | moved-lazy | `gateway.platforms.base` |
| `MessageType` | moved-lazy | `gateway.platforms.event` |
### `plugins.platforms.discord.adapter`
@@ -2602,7 +2602,7 @@ to the public equivalent or the new module. Test monkeypatch seams are likewise
| name | kind | new location |
|---|---|---|
| `ProcessingOutcome` | moved-lazy | `gateway.platforms.base` |
| `ProcessingOutcome` | moved-lazy | `gateway.platforms.event` |
| `resolve_sidecar_dir` | moved-lazy | `plugins.platforms.photon.sidecar_paths` |
### `plugins.platforms.photon.auth`