hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

fix(approval): require confirmation for package uninstalls

Browse Source 
`npm uninstall -g`, pnpm/yarn remove, `pip uninstall` and `brew uninstall`
remove software outside the project yet matched no dangerous-command
pattern, so the agent ran them without asking (#10199). Add one
"package manager uninstall" rule per manager; installs and updates stay
unprompted.

Hand-ported from PR #64175 (the patterns moved from tools/approval.py to
tools/approval_detection.py after it was opened).
This commit is contained in:
konsisumer
2026-07-17 00:15:34 +02:00
committed by Teknium
parent 92a8398087
commit 85ce25687e
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tools/approval_detection.py
View File

@@ -393,6 +393,15 @@ DANGEROUS_PATTERNS = [
(r'\bsudo\b[^;|&\n]*?\s+(?:-s\b|--st[a-z]*\b|-a\b|--a[a-z]*\b)', "sudo with privilege flag (stdin/askpass/shell/list)"),
# Combined short-flag form (-nS, -sa, -las).
(r'\bsudo\b[^;|&\n]*?\s+-[a-z]*[sa][a-z]*\b', "sudo with combined-flag privilege escalation"),
# Package-manager uninstall commands can remove installed software outside
# the current project (notably `npm uninstall -g`). Treat their destructive
# subcommands like other state-removing operations while leaving installs
# and updates alone.
(r'\bnpm\s+(?:-[^\s]+\s+)*(?:uninstall|unlink|remove|rm|r|un)\b', "package manager uninstall"),
(r'\bpnpm\s+(?:-[^\s]+\s+)*(?:uninstall|remove|rm|un)\b', "package manager uninstall"),
(r'\byarn\s+(?:global\s+)?(?:uninstall|remove)\b', "package manager uninstall"),
(r'\bpip(?:3)?\s+(?:-[^\s]+\s+)*uninstall\b', "package manager uninstall"),
(r'\bbrew\s+(?:uninstall|remove|rm)\b', "package manager uninstall"),
]