From 78dfd6e6e7df5f2ddb5e90064c4a29d416acd69f Mon Sep 17 00:00:00 2001 From: kshitijk4poor <82637225+kshitijk4poor@users.noreply.github.com> Date: Tue, 22 Sep 2026 13:20:41 +0530 Subject: [PATCH] docs(skills): explain why an undecodable ledger warns, without review jargon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The docstring of test_list_entries_treats_an_undecodable_ledger_as_empty_and_warns cited "(re-gate M8/S1)" (tests/tools/test_skill_ledger_delta.py:88; re-gate G2 S1) — a review-process artifact meaningless to future readers. State the behavioural reason instead: silence would make a corrupt ledger look like a fresh install with no history. --- tests/tools/test_skill_ledger_delta.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tools/test_skill_ledger_delta.py b/tests/tools/test_skill_ledger_delta.py index 9b416a46d4..a478324fa4 100644 --- a/tests/tools/test_skill_ledger_delta.py +++ b/tests/tools/test_skill_ledger_delta.py @@ -86,7 +86,8 @@ def test_compact_leaves_an_undecodable_ledger_untouched(ledger_home, caplog): def test_list_entries_treats_an_undecodable_ledger_as_empty_and_warns(ledger_home, caplog): """A ledger that exists but is not UTF-8 lists as empty (rollback then fails closed on - ``get_entry`` -> None) and, unlike a merely missing ledger, is warned about (re-gate M8/S1).""" + ``get_entry`` -> None) and, unlike a merely missing ledger, is warned about: corruption + would otherwise be indistinguishable from a fresh install with no history.""" from tools import skill_ledger ledger = skill_ledger.ledger_path() ledger.parent.mkdir(parents=True, exist_ok=True)