hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

test(email): pin both spf clause orders and name the auth-results test for what it covers

Browse Source
This commit is contained in:
kshitijk4poor
2026-09-27 17:30:00 +05:30
committed by kshitij
parent 3f4533b9de
commit 6f7a7991bb
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/gateway/test_email.py
View File

@@ -1208,7 +1208,7 @@ class TestSenderAuthentication(unittest.TestCase):
addr = _extract_email_address(from_addr) addr = _extract_email_address(from_addr)
return _verify_sender_authentication(msg, addr, authserv_id=authserv_id) return _verify_sender_authentication(msg, addr, authserv_id=authserv_id)
def test_dmarc_pass_authenticates(self): def test_auth_results_verdicts(self):
ok, reason = self._verify( ok, reason = self._verify(
"Admin <admin@example.com>", "Admin <admin@example.com>",
["mx.google.com; dmarc=pass header.from=example.com; spf=pass"], ["mx.google.com; dmarc=pass header.from=example.com; spf=pass"],
@@ -1240,6 +1240,7 @@ class TestSenderAuthentication(unittest.TestCase):
"mx.google.com; spf=fail smtp.mailfrom=a.spf=pass@example.com; dmarc=fail header.from=example.com", "mx.google.com; spf=fail smtp.mailfrom=a.spf=pass@example.com; dmarc=fail header.from=example.com",
'mx.google.com; dkim=pass header.d=evil.test header.i="x header.d=example.com y"@evil.test', 'mx.google.com; dkim=pass header.d=evil.test header.i="x header.d=example.com y"@evil.test',
"mx.google.com; spf=pass smtp.mailfrom=example.com; spf=fail smtp.mailfrom=evil.test", "mx.google.com; spf=pass smtp.mailfrom=example.com; spf=fail smtp.mailfrom=evil.test",
"mx.google.com; spf=fail smtp.mailfrom=evil.test; spf=pass smtp.mailfrom=example.com",
"mx.google.com; dkim=pass header.d=evil.test; dkim=fail header.d=example.com", "mx.google.com; dkim=pass header.d=evil.test; dkim=fail header.d=example.com",
'mx.google.com; dkim=pass header.i="x header.d=example.com"@evil.test', 'mx.google.com; dkim=pass header.i="x header.d=example.com"@evil.test',
# an escaped quote keeps the quoted-string open, so no dmarc clause is smuggled out of it # an escaped quote keeps the quoted-string open, so no dmarc clause is smuggled out of it