hermes-admin/hermes-agent
1
0
Fork 0
Code Issues Pull Requests Actions 33 Packages Projects Releases Wiki Activity

test(desktop): neutralize the unshare sandbox probe in the Ctrl-C exit test

Browse Source 
The Ctrl-C test's global subprocess.run patch also intercepts the Linux
sandbox fixup's `unshare --user --map-root-user` user-namespace probe,
which cmd_gui runs from _packaged_desktop_launch_command BEFORE the
attached launch — outside the KeyboardInterrupt handler under test. The
interrupt escaped and aborted the whole pytest file (CI Linux:
'test_gui_command.py:1138: KeyboardInterrupt' on the merge ref; reproduced
in a Linux container with --full-trace showing the probe as the escape
point). Stub _desktop_linux_userns_sandbox_available to True, matching the
file's convention of neutralizing platform plumbing the test is not about.
Both pre-launch subprocess callers (desktop-entry refresh, unshare probe)
are now neutralized; the only mocked subprocess.run call left is the
attached launch itself.
This commit is contained in:
Hermes Agent
2026-09-25 18:08:28 -05:00
committed by brooklyn!
parent 3f2c24d41f
commit 6c32a31d30
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/hermes_cli/test_gui_command.py
View File

@@ -1126,11 +1126,14 @@ def test_gui_foreground_launch_ctrl_c_exits_cleanly(tmp_path, monkeypatch, capsy
root = _make_desktop_tree(tmp_path)
monkeypatch.setattr(cli_main, "PROJECT_ROOT", root)
# Patching hermes_cli.main.subprocess.run swaps the shared stdlib module's
# attribute, so EVERY subprocess.run in the process raises. On Linux the
# best-effort desktop-entry install runs refresh_desktop_databases →
# subprocess.run BEFORE the attached launch — outside the KeyboardInterrupt
# handler under test — so neutralize it like the other foreground tests do.
# attribute, so EVERY subprocess.run in the process raises. Two best-effort
# pre-launch paths call it BEFORE the attached launch — outside the
# KeyboardInterrupt handler under test — so neutralize both the way the
# other foreground tests do: the Linux desktop-entry install (its
# refresh_desktop_databases probe) and the sandbox fixup's `unshare`
# user-namespace probe.
monkeypatch.setattr(main_desktop, "_register_linux_desktop_entry", lambda **kw: None)
monkeypatch.setattr(main_desktop, "_desktop_linux_userns_sandbox_available", lambda: True)
packaged_exe = _make_packaged_executable(root, monkeypatch)
ok = subprocess.CompletedProcess([], 0)