From 6973f2622d7c9bf6caee7d3e0c6777d54f0f64c9 Mon Sep 17 00:00:00 2001 From: Shenrui Ma <115921185+Shenrui-Ma@users.noreply.github.com> Date: Tue, 15 Sep 2026 11:43:00 -0700 Subject: [PATCH] fix(codex): target hermes-tools in Kanban worker overrides Dispatcher-owned Kanban workers on the codex app-server runtime injected their HERMES_KANBAN_* scope into `mcp_servers.hermes-mcp.env.*`, but the runtime migration registers Hermes' MCP callback as `[mcp_servers.hermes-tools]`. The override therefore materialised a second, env-only server entry that codex rejects at bootstrap ("invalid transport in `mcp_servers.hermes-mcp`"), so no worker could initialize. Point the overrides at the entry that actually exists. Salvaged from #107337 (its 147-line parametrized test file is replaced by two invariant tests in a follow-up commit). #111711 proposed the identical two lines. Fixes #111707 Co-authored-by: KoNit-K <124019182+KoNit-K@users.noreply.github.com> --- agent/transports/codex_app_server.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/agent/transports/codex_app_server.py b/agent/transports/codex_app_server.py index 1681605aa9..e9be0c803a 100644 --- a/agent/transports/codex_app_server.py +++ b/agent/transports/codex_app_server.py @@ -105,8 +105,8 @@ class CodexAppServerClient: if owned_task: for key in (*KANBAN_ENV_KEYS, "HERMES_KANBAN_DB", "HERMES_KANBAN_BOARD"): if key in os.environ: - cmd += ["-c", f"mcp_servers.hermes-mcp.env.{key}={json.dumps(os.environ[key])}"] - cmd += ["-c", f'mcp_servers.hermes-mcp.env.{DELEGATED_CHILD_ENV_MARKER}=""'] + cmd += ["-c", f"mcp_servers.hermes-tools.env.{key}={json.dumps(os.environ[key])}"] + cmd += ["-c", f'mcp_servers.hermes-tools.env.{DELEGATED_CHILD_ENV_MARKER}=""'] spawn_env = delegated_child_subprocess_env(spawn_env) # Kanban workers must write handoff/status to the board DB outside the # workspace: keep the sandbox on, add the Kanban root as writable.