From 63ec22e797ba73b369d1bcc0bcc69622edd9d7e8 Mon Sep 17 00:00:00 2001 From: kshitijk4poor <82637225+kshitijk4poor@users.noreply.github.com> Date: Tue, 8 Sep 2026 19:44:59 +0530 Subject: [PATCH] fix: correct two stale comments/docs strings left out of the docs batch The docs batch (#105782-#105787, tracking #105788) fixed the website docs but flagged two in-code strays it could not touch: - hermes_cli/tips.py:121 still said delegate_task "spawns up to 3 concurrent sub-agents"; the default has been 10 since the v33 config migration (config_defaults.py:1256, config_migrations.py:613). - hermes_cli/config_defaults.py:1778 said "remote backends run per-call", contradicted by tools/code_kernel_remote.py (session kernels on remote backends, failing open to per-call only when the backend cannot spawn one) since #96991. Comment-only changes: tips.py list entry updated, config_defaults.py comment rewritten to match the actual kernel lifecycle. No behaviour change. Validated: test_tips.py 6 passed; ruff, check-windows-footguns, and check_compat_pointers all clean. Refs #105788 (crumb noted in the issue body). --- hermes_cli/config_defaults.py | 3 ++- hermes_cli/tips.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hermes_cli/config_defaults.py b/hermes_cli/config_defaults.py index 3451a15287..40d8381407 100644 --- a/hermes_cli/config_defaults.py +++ b/hermes_cli/config_defaults.py @@ -1775,7 +1775,8 @@ DEFAULT_CONFIG = { # (sys.executable): max isolation, project deps/relative paths won't work. Env scrubbing # (*_API_KEY, *_TOKEN, *_SECRET, ...) and the tool whitelist apply in both modes. "mode": "project", - # Session kernels are always on locally (`kernel_mode` is ignored; remote backends run + # Session kernels are always on locally (`kernel_mode` is ignored) and remotely + # (tools/code_kernel_remote.py; a backend that cannot spawn a kernel fails open to # per-call). One kernel per (session owner, mode, interpreter, cwd, tool-set) keeps state # across calls and turns; subagents get their own. Kernels die with the session, after # kernel_idle_timeout idle seconds, or by LRU eviction past max_session_kernels. A diff --git a/hermes_cli/tips.py b/hermes_cli/tips.py index 7cf29f589e..0fb8b5f248 100644 --- a/hermes_cli/tips.py +++ b/hermes_cli/tips.py @@ -118,7 +118,7 @@ TIPS = [ "provider_routing controls OpenRouter provider sorting, whitelisting, and blacklisting.", # --- Tools & Capabilities --- "execute_code runs Python scripts that call Hermes tools programmatically — results stay out of context.", - "delegate_task spawns up to 3 concurrent sub-agents by default (delegation.max_concurrent_children) with isolated contexts for parallel work.", + "delegate_task spawns up to 10 concurrent sub-agents by default (delegation.max_concurrent_children) with isolated contexts for parallel work.", "web_extract works on PDF URLs — pass any PDF link and it converts to markdown.", "search_files is ripgrep-backed and faster than grep — use it instead of terminal grep.", "patch uses 9 fuzzy matching strategies so minor whitespace differences won't break edits.",