From 5e131ff9cc2a1fd775f21e975cdf50bee2baf9ff Mon Sep 17 00:00:00 2001
From: teknium1 <127238744+teknium1@users.noreply.github.com>
Date: Sat, 19 Sep 2026 22:31:03 -0700
Subject: [PATCH] test(web): trim the xai gate coverage to two invariants

Keep the production-entry-point e2e (XAI_API_KEY alone -> zero web tools,
+TAVILY_API_KEY -> both) and the explicit web.backend: xai control; the
three unit-level duplicates asserted the same gate through patched probes.
---
 tests/tools/test_web_tools_config.py | 39 ----------------------------
 1 file changed, 39 deletions(-)

diff --git a/tests/tools/test_web_tools_config.py b/tests/tools/test_web_tools_config.py
index 0333072df1..104236292a 100644
--- a/tests/tools/test_web_tools_config.py
+++ b/tests/tools/test_web_tools_config.py
@@ -576,27 +576,6 @@ class TestCheckWebApiKey:
             from tools.web_tools import check_web_api_key
             assert check_web_api_key() is False
 
-    def test_xai_credentials_do_not_light_web_tools(self):
-        """xAI credentials back TTS/media tools only: ``xai`` is in
-        _BUILTIN_AVAILABILITY for bookkeeping but no web provider is ever
-        dispatched to it, so it must not satisfy the web_search/web_extract
-        gate; otherwise the tools register with no servable backend. Note the
-        probe must be patched at ``has_xai_credentials``: _BUILTIN_AVAILABILITY
-        holds a direct reference to ``_xai_available``, so patching the module
-        attribute would not reach the dict entry."""
-        with patch("tools.web_tools._load_web_config", return_value={}), \
-             patch("tools.xai_http.has_xai_credentials", return_value=True):
-            from tools.web_tools import check_web_api_key
-            assert check_web_api_key() is False
-
-    def test_xai_credentials_plus_web_key_still_pass(self):
-        """Excluding xai from the gate does not weaken detection of a real web key."""
-        with patch("tools.web_tools._load_web_config", return_value={}), \
-             patch("tools.xai_http.has_xai_credentials", return_value=True), \
-             patch.dict(os.environ, {"TAVILY_API_KEY": "test-key"}):
-            from tools.web_tools import check_web_api_key
-            assert check_web_api_key() is True
-
     def test_configured_xai_backend_still_lights_gate(self):
         """An explicit ``web.backend: xai`` selection still counts toward the
         gate: the bundled web-xai plugin's provider can serve it when loaded,
@@ -606,24 +585,6 @@ class TestCheckWebApiKey:
             from tools.web_tools import check_web_api_key
             assert check_web_api_key() is True
 
-    def test_registered_xai_provider_lights_gate_via_registry(self):
-        """Skipping the bare xai credential probe does not hide real
-        availability: when the web-xai plugin IS registered and available,
-        get_active_search_provider returns it and the plugin path lights the
-        gate on its own."""
-        class _XaiProvider:
-            name = "xai"
-
-            def is_available(self):
-                return True
-
-        with patch("tools.web_tools._load_web_config", return_value={}), \
-             patch("tools.xai_http.has_xai_credentials", return_value=False), \
-             patch("agent.web_search_registry.get_active_search_provider",
-                   return_value=_XaiProvider()):
-            from tools.web_tools import check_web_api_key
-            assert check_web_api_key() is True
-
     def test_xai_only_env_end_to_end_toolset_gate(self, monkeypatch, tmp_path):
         """E2e through the registry: a real XAI_API_KEY env var -> the real
         has_xai_credentials probe -> check_fn -> get_tool_definitions. The web