From 4de32676cecf45f8ce3adae3d98932d4241b2353 Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Wed, 2 Sep 2026 22:53:31 -0700 Subject: [PATCH] refactor(plugins/google_meet): table-drive validate_request checks (285k-case fuzz parity vs base) --- plugins/google_meet/node/protocol.py | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/plugins/google_meet/node/protocol.py b/plugins/google_meet/node/protocol.py index 623fe6333c..c50fdf3d09 100644 --- a/plugins/google_meet/node/protocol.py +++ b/plugins/google_meet/node/protocol.py @@ -72,18 +72,12 @@ def validate_request(msg: Dict[str, Any], expected_token: str) -> Tuple[bool, st """Return ``(True, "")`` or ``(False, )``; reasons are safe to send back to the client.""" if not isinstance(msg, dict): return False, "envelope must be a dict" - t = msg.get("type") - if not _nonempty_str(t): - return False, "missing or non-string 'type'" - if t not in VALID_REQUEST_TYPES: - return False, f"unknown request type: {t!r}" - if not _nonempty_str(msg.get("id")): - return False, "missing or non-string 'id'" - token = msg.get("token") - if not _nonempty_str(token): - return False, "missing token" - if token != expected_token: - return False, "token mismatch" - if not isinstance(msg.get("payload"), dict): - return False, "payload must be a dict" - return True, "" + t, token = msg.get("type"), msg.get("token") + checks = ( # ordered, lazily evaluated: first failing check wins + (lambda: _nonempty_str(t), "missing or non-string 'type'"), + (lambda: t in VALID_REQUEST_TYPES, f"unknown request type: {t!r}"), + (lambda: _nonempty_str(msg.get("id")), "missing or non-string 'id'"), + (lambda: _nonempty_str(token), "missing token"), + (lambda: token == expected_token, "token mismatch"), + (lambda: isinstance(msg.get("payload"), dict), "payload must be a dict")) + return next(((False, reason) for ok, reason in checks if not ok()), (True, ""))