From 2370a630792d59afe6fa164e1ffabcce77337f85 Mon Sep 17 00:00:00 2001 From: teknium1 <127238744+teknium1@users.noreply.github.com> Date: Wed, 16 Sep 2026 12:33:37 -0700 Subject: [PATCH] fix: drop env_type from the builders' signature comment The dispatcher no longer passes env_type to the built-in environment builders (that was the TypeError this PR fixes); only the plugin-registry fallback receives it. The comment still listed it, which reintroduces the confusion the fix removed. Review follow-up on #113250. --- tools/terminal_tool_backends.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/terminal_tool_backends.py b/tools/terminal_tool_backends.py index 7bcb060449..0ee5025689 100644 --- a/tools/terminal_tool_backends.py +++ b/tools/terminal_tool_backends.py @@ -124,7 +124,8 @@ def _modal_unavailable_reason(modal_state: Dict[str, Any]) -> tuple[str, str]: f"Modal backend selected but no direct Modal credentials/config {found}.") -# --- Environment builders. Signature: (*, env_type, image, cwd, timeout, cc, task_id, ssh_config, host_cwd) +# --- Environment builders. Signature: (*, image, cwd, timeout, cc, task_id, ssh_config, host_cwd) +# (env_type is only forwarded to the plugin-registry fallback, not to the built-in builders.) def _build_local_env(*, cwd, timeout, **_): return _LocalEnvironment(cwd=cwd, timeout=timeout)