From 07c53102957b833fa150bdd3ddd4ca42cae60dda Mon Sep 17 00:00:00 2001
From: kshitijk4poor <82637225+kshitijk4poor@users.noreply.github.com>
Date: Sun, 27 Sep 2026 12:11:58 +0530
Subject: [PATCH] test(simplex): trim salvaged allowlist tests to the two
 invariants

Drop test_simplex_allowlist_rejects_colliding_display_name: it passes on
the unfixed base (the allowlist held the contactId, not the colliding
name), so it never guarded #44729. Drop the setup-prompt string check as a
change-detector. Keep rejects_display_name_only (red on base) and
accepts_numeric_contact_id (contactId path still works).
---
 tests/gateway/test_simplex_plugin.py          |  8 -----
 .../gateway/test_unauthorized_dm_behavior.py  | 36 -------------------
 2 files changed, 44 deletions(-)

diff --git a/tests/gateway/test_simplex_plugin.py b/tests/gateway/test_simplex_plugin.py
index 17d0a1ebfc..6c96325dfb 100644
--- a/tests/gateway/test_simplex_plugin.py
+++ b/tests/gateway/test_simplex_plugin.py
@@ -483,11 +483,3 @@ def test_multiplex_scope_reads_profile_own_env_not_default(
     seeded = _env_enablement()
     assert seeded == {"ws_url": "ws://profile:5225", "group_allowed": "g1"}
     assert check_requirements() is True
-
-
-def test_setup_prompts_no_longer_offer_display_names():
-    """The setup wizard must not suggest display names as SIMPLEX_ALLOWED_USERS
-    values: authorization only matches the stable numeric contactId, and a
-    display-name entry would silently fail closed (#44729)."""
-    prompts = dict(_simplex._SETUP_PROMPTS)
-    assert "display name" not in prompts["SIMPLEX_ALLOWED_USERS"].lower()
diff --git a/tests/gateway/test_unauthorized_dm_behavior.py b/tests/gateway/test_unauthorized_dm_behavior.py
index dc6754613d..b0d2745cbc 100644
--- a/tests/gateway/test_unauthorized_dm_behavior.py
+++ b/tests/gateway/test_unauthorized_dm_behavior.py
@@ -159,42 +159,6 @@ def test_simplex_allowlist_rejects_display_name_only(monkeypatch):
     assert runner._is_user_authorized(source) is False
 
 
-def test_simplex_allowlist_rejects_colliding_display_name(monkeypatch):
-    """Security regression guard: a contact whose contactId is NOT in the
-    allowlist must stay unauthorized even when they adopt the display name of
-    an allowed contact (#44729)."""
-    _clear_auth_env(monkeypatch)
-    monkeypatch.delenv("SIMPLEX_ALLOWED_USERS", raising=False)
-    # Operator allowed contactId "4" (who happens to use display name "hujikuji")
-    monkeypatch.setenv("SIMPLEX_ALLOWED_USERS", "4")
-
-    from gateway.platform_registry import platform_registry, PlatformEntry
-    platform_registry.register(PlatformEntry(
-        name="simplex",
-        label="SimpleX Chat",
-        adapter_factory=lambda cfg: None,
-        check_fn=lambda: True,
-        allowed_users_env="SIMPLEX_ALLOWED_USERS",
-        allow_all_env="SIMPLEX_ALLOW_ALL_USERS",
-    ))
-
-    simplex = Platform("simplex")
-    runner, _adapter = _make_runner(
-        simplex,
-        GatewayConfig(platforms={simplex: PlatformConfig(enabled=True)}),
-    )
-
-    # Attacker: different contactId ("7") but same display name as the allowed user
-    source = SessionSource(
-        platform=simplex,
-        user_id="7",              # different contactId — NOT in allowlist
-        chat_id="attacker",
-        user_name="hujikuji",     # same display name as allowed user
-        chat_type="dm",
-    )
-    assert runner._is_user_authorized(source) is False
-
-
 def test_simplex_allowlist_accepts_numeric_contact_id(monkeypatch):
     """SIMPLEX_ALLOWED_USERS continues to match the stable numeric contactId
     (user_id) — the one identity form a SimpleX contact cannot forge."""